SWORDIcon indicating the project type

SWORD

Uploaded image for project: 'SWORD'
  1. SWORD
  2. API-204

Small improvements to allow compilation with clang and some fixes

          Details

          • Type: Bug
          • Status: Closed (View Workflow)
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.40
          • Fix Version/s: 1.8.0
          • Component/s: core
          • Labels:
            None
          • Environment:

            OS: OpenBSD 6.2 / adJ 6.2

            Compiler: clang 4.0.0

             

             

             

            Description

            clang complains about some comparision of pointers with integer, and some were wrong.

            The attached patch solves the problems.

            I found the problem when updating the port of sword for adJ from 6.1 to 6.2. See

            https://en.wikipedia.org/wiki/AdJ

              Attachments

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                scribe Troy A Griffitts added a comment - - edited

                Vladimir Támara Patiño, thank you so much.  We are just about to push out 1.8.0 and have an RC5 available.  I believe we have most of these fixes already included but it would be very helpful if you had a look at our RC to determine if we missed anything.  I will review as well and hopefully between us, we will not miss any improvements from your great work.  Thank you.

                 http://crosswire.org/sword/sword-1.7.905.tar.gz

                Troy

                Show
                scribe Troy A Griffitts added a comment - - edited Vladimir Támara Patiño , thank you so much.  We are just about to push out 1.8.0 and have an RC5 available.  I believe we have most of these fixes already included but it would be very helpful if you had a look at our RC to determine if we missed anything.  I will review as well and hopefully between us, we will not miss any improvements from your great work.  Thank you.   http://crosswire.org/sword/sword-1.7.905.tar.gz Troy
                Hide
                Permalink
                scribe Troy A Griffitts added a comment -

                Confirmed all of these patches are fixed in 1.8.0RC5

                Show
                scribe Troy A Griffitts added a comment - Confirmed all of these patches are fixed in 1.8.0RC5
                Hide
                Permalink
                vtamara Vladimir Támara Patiño added a comment -

                The archive you referenced (  http://crosswire.org/sword/sword-1.7.905.tar.gz ) includes all the fixes.

                 

                Good job wih Sword! Thank you very much.

                Show
                vtamara Vladimir Támara Patiño added a comment - The archive you referenced (  http://crosswire.org/sword/sword-1.7.905.tar.gz  ) includes all the fixes.   Good job wih Sword! Thank you very much.
                Hide
                Permalink
                vtamara Vladimir Támara Patiño added a comment -

                May God keep blessing you all.

                 

                Show
                vtamara Vladimir Támara Patiño added a comment - May God keep blessing you all.  

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    vtamara Vladimir Támara Patiño
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: