Details
-
Type: Bug
-
Status: Open (View Workflow)
-
Priority: Minor
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: o.c.jsword.book.filter.thml
-
Labels:None
Description
I believe there is some missing code in thml.ATag. In StrongsRealGreek there are references like:
<a href="sword://StrongsRealGreek/01909">1909</a>
and the above is currently converted to OSIS as:
<reference>1909</reference>
However I think it should be:
<reference osisRef="sword://StrongsRealGreek/01909">1909</reference>
Joe has left the following comment in ATag which seems to confirm that some code is missing:
// LATER(joe): put the correct reference here
I added the following just before Joe's comment which seems to fix the problem:
String href = attrs.getValue("href");
if (href!=null && !href.isEmpty())
I will attach the amended ATag.java and also a junit test. If nobody comments adversely before next week then I can check in the junit and fixed code next week.
There is probably also an issue with xml like "<a name="01993">1993</a>" which is not addressed by the attached fix.