Uploaded image for project: 'Module Tools'
  1. Module Tools
  2. MODTOOLS-77

osis2mod misplaces titles for <div type="majorSection"> segments

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: osis2mod
    • Labels:
      None

      Description

      Use of <div type="majorSection"> is typically limited to the 5 books in Psalms. Each of these sections can and frequently will have a <title>BOOK #</title> with its book number 1-5 substituted in.

      For Book 1, which starts with Psalm 1 this title is added to the book heading in Psalm.0, which visually places it in the correct location in most front ends. However, in Books 2-5 these titles are appended to the end of the previous Psalm. So, for instance, the last verse of Psalm 41 will include "BOOK 2" at the tail of it instead of having that header be at the start of Psalm 42.

      The attached patch pushes all content between the opening of a div[@type=majorSection] and the following chapter start into verse 0 of the following chapter. This makes the 5 books consistent with titles in Psalm.1.0, Psalm.42.0, etc and more importantly makes the titles render consistently and correctly in front end output.

        Attachments

          Activity

            People

            • Assignee:
              dmsmith DM Smith
              Reporter:
              greg.hellings Greg Hellings
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: